fix(realtime-ws): stop accidental cancellation error #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9937e2f The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dkundel-openai
force-pushed
the
dkundel/fix-interruptions-ws
branch
from
52f9f33 to
a1cb6bf
Compare
bakks
approved these changes
Jul 16, 2025
Member
|
Create changeset and get it merged 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on the turn detection settings the Realtime API might cancel an ongoing response automatically which in the current code might run into occasional race conditions with the
this.#ongoingResponsecheck which in turn causes errors.This change shuffles the logic around so that if an interruption is happening because of turn detection it will check if the session config has cancellation of responses enabled and only cancel if not. For other interruption calls like guardrails or manual interruptions we will still perform an interruption.
This change isn't needed in WebRTC because the turn detection based interruptions happen server side.